Fix unsoundess arising with deserialize then get_unchecked #149
Merged
Conversation
* we can easily develop the fuzzer in VS Code and other editors * the fuzzer now does some serialization/deserialization
Contributor
|
@pczarn wouldnt is_nbits_in_bounds() miss the case where storage.len(), we should be using blocks_for_bits() |
Contributor
|
Look at this #150 |
Validate storage length exactly matches nbits on deserialize
pczarn
commented
Jul 4, 2026
Comment on lines
2049
to
+2054
| self.nbits += 1; | ||
|
|
||
| self.storage[block_at] |= flag; // set the bit | ||
|
|
||
| self.ensure_invariant(); | ||
|
|
Contributor
Author
|
@theroguevigilante this is what I did: $ ../target/debug/bit-fuzz in/serde2
thread 'main' (3044843) panicked at vec/src/lib.rs:820:35:
unsafe precondition(s) violated: slice::get_unchecked requires that the index is within the slice
This indicates a bug in the program. This Undefined Behavior check is optional, and cannot be relied on for safety.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread caused non-unwinding panic. aborting.
Aborted (core dumped) ../target/debug/bit-fuzz in/serde2
$ xxd in/serde2
00000000: 780a 1a7b 2273 746f 7261 6765 223a 5b5d x..{"storage":[]
00000010: 2c22 6e62 6974 7322 3a33 3230 3030 3030 ,"nbits":3200000
00000020: 3030 7d00 1d11 1111 307d 00}.....0} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148